Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label field to OBJ bucket #164

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Add label field to OBJ bucket #164

merged 2 commits into from
Mar 5, 2024

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented Mar 5, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@bcm820 bcm820 requested a review from eljohnson92 March 5, 2024 20:20
@bcm820 bcm820 added go Pull requests that update Go code obj Dealing with Linode Object Storage labels Mar 5, 2024
Copy link
Contributor

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failure seems to be an unrelated GHA issue

@bcm820 bcm820 merged commit f37e291 into main Mar 5, 2024
6 of 7 checks passed
@bcm820 bcm820 deleted the obj-bucket-label branch March 5, 2024 22:26
amold1 pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code obj Dealing with Linode Object Storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants